On Jan 12, 2015, at 10:04 AM, Peter Maydell wrote: > On 12 January 2015 at 14:51, Programmingkid <programmingk...@gmail.com> wrote: >> On Jan 12, 2015, at 4:12 AM, Gerd Hoffmann wrote: >>> I suggest to add fixed endian defines for 32bpp to >>> include/ui/qemu-pixman.h (there already is one for 24bpp), then use >>> these to avoid cluttering the cocoa code with HOST_WORDS_BIGENDIAN >>> #defines. >>> >>> The colorspace bits look sane to me, I'm not macos x expert enough to >>> really justify. >> >> If someone volunteered to test any code changes on their PowerPC Mac, >> then I would try this. > > It generally works the other way around -- if the documentation for > something says X, then you write the code assuming that, and test it > on the platforms you have access to, and trust that the others will > work anyway. You don't write code that the documentation says won't > work portably just because it happens to work on the platforms you > have access to... > [In this case "X" is "pixman formats are host-endian".]
Interesting idea. Will try it this way in future patches.
