On 7 January 2015 at 10:34, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 7 January 2015 at 06:13, Paolo Bonzini <pbonz...@redhat.com> wrote: >> On 25/11/2014 15:17, Peter Maydell wrote: >>> * should we squash the revert and reimplement patches together? >>> (avoids bisection break but makes the revert-and-reimplement less clear) >> >> I think we can do that, provided the reimplemented functions are in >> different places than the originals, so that the revert-and-reimplement >> is still clear from the diff. > > OK. I'll make sure I do that with the next version.
Having tried it, this is pretty straightforward for the uint64_to_* functions, but the SNAN_BIT_IS_ONE code doesn't work out so nicely, because it's removing and reimplementing a lot of #ifdefs inside functions, rather than whole functions. We could squash together for the commits to master but leave the split commits in the tarball archive? -- PMM
