Am 23.12.2014 um 23:18 schrieb Peter Maydell: > These two patches fix warnings generated by clang; I'm hoping we can > clear up the handful of remaining clang warnings so I can turn on > warnings-as-errors for my builds I do before applying pullreqs, and > then we can keep the clang builds warning-free. > > For the disassembler code, I opted to simply delete the unused > data tables. The other thing we've done in some of the disassemblers > is to just #if-0 out the code, but that's mostly been where it's > something we might use in future, and I think this table is for > the benefit of the assembler, not the disassembler. > > Peter Maydell (2): > target-s390x: Mark op_csp() as !CONFIG_USER_ONLY > disas/s390.c: Remove unused variables > > disas/s390.c | 35 ----------------------------------- > target-s390x/translate.c | 2 ++ > 2 files changed, 2 insertions(+), 35 deletions(-)
In the subject line and in the commit message of patch 1 'op_csp' should be replaced by 'check_privileged'. Then for both patches you may add Reviewed-by: Stefan Weil <s...@weilnetz.de>