On 22 December 2014 at 11:14, Peter Maydell <peter.mayd...@linaro.org> wrote: > Hi. I'm afraid this fails "make check" on MacOSX: > /Users/pm215/src/qemu/tests/qemu-iotests-quick.sh > /Users/pm215/src/qemu/tests/qemu-iotests/common.config: line 158: > /bin/true: No such file or directory > check: failed to source common.config > > On OSX "true" is /usr/bin/true. common.config should just use > "true" here I think, and let the shell figure out where it is > (typically a builtin, obviously).
common.rc and common.filter also have this bug. With those fixed, 'make check-block' now runs two tests (most are skipped with "not suitable for this OS: Darwin"), of which 058 fails: ===begin=== 058 [12:01:48] [12:01:49] - output mismatch (see 058.out.bad) --- /Users/pm215/src/qemu/tests/qemu-iotests/058.out 2014-02-17 23:38:30.000000000 +0000 +++ 058.out.bad 2014-12-22 12:01:49.000000000 +0000 @@ -1,44 +1,37 @@ QA output created by 058 == preparing image == -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 -wrote 4096/4096 bytes at offset 4096 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) -wrote 4096/4096 bytes at offset 8192 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) -wrote 4096/4096 bytes at offset 4096 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) -wrote 4096/4096 bytes at offset 8192 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 cluster_size=65536 lazy_refcounts=off +wite [-bcCpqz] [-P patten ] off len -- wites a numbe of bytes at a specified offset +wite [-bcCpqz] [-P patten ] off len -- wites a numbe of bytes at a specified offset +wite [-bcCpqz] [-P patten ] off len -- wites a numbe of bytes at a specified offset +wite [-bcCpqz] [-P patten ] off len -- wites a numbe of bytes at a specified offset No errors were found on the image. +Image end offset: 393216 == verifying the image file with patterns == -read 4096/4096 bytes at offset 4096 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) -read 4096/4096 bytes at offset 8192 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +ead [-abCpqv] [-P patten [-s off] [-l len]] off len -- eads a numbe of bytes at a specified offset +ead [-abCpqv] [-P patten [-s off] [-l len]] off len -- eads a numbe of bytes at a specified offset == verifying the exported snapshot with patterns, method 1 == -read 4096/4096 bytes at offset 4096 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) -read 4096/4096 bytes at offset 8192 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +ead [-abCpqv] [-P patten [-s off] [-l len]] off len -- eads a numbe of bytes at a specified offset +ead [-abCpqv] [-P patten [-s off] [-l len]] off len -- eads a numbe of bytes at a specified offset == verifying the exported snapshot with patterns, method 2 == -read 4096/4096 bytes at offset 4096 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) -read 4096/4096 bytes at offset 8192 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +ead [-abCpqv] [-P patten [-s off] [-l len]] off len -- eads a numbe of bytes at a specified offset +ead [-abCpqv] [-P patten [-s off] [-l len]] off len -- eads a numbe of bytes at a specified offset +qemu-img: Could not open '-l': Could not open '-l': No such file or directory == verifying the converted snapshot with patterns, method 1 == -read 4096/4096 bytes at offset 4096 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) -read 4096/4096 bytes at offset 8192 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +qemu-io: can't open device .converted: Could not open '.converted': No such file or directory +no file open, try 'help open' +qemu-io: can't open device .converted: Could not open '.converted': No such file or directory +no file open, try 'help open' +qemu-img: Could not open '-l': Could not open '-l': No such file or directory == verifying the converted snapshot with patterns, method 2 == -read 4096/4096 bytes at offset 4096 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) -read 4096/4096 bytes at offset 8192 -4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +qemu-io: can't open device .converted: Could not open '.converted': No such file or directory +no file open, try 'help open' +qemu-io: can't open device .converted: Could not open '.converted': No such file or directory +no file open, try 'help open' *** done ===endit=== Something very odd is happening here: why are all the "r"s apparently missing from those error messages? -- PMM