On Wed, Dec 10, 2014 at 07:44:04PM +0000, Peter Maydell wrote: > On 10 December 2014 at 19:26, Eduardo Habkost <ehabk...@redhat.com> wrote: > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > > --- > > exec.c | 1 - > > hw/virtio/virtio.c | 1 - > > include/exec/exec-all.h | 2 ++ > > 3 files changed, 2 insertions(+), 2 deletions(-) > > I thought this prototype was deliberately not in a generally > included header file because it's really not something that > should be needed by most code. If we do want to move it into > a header then we definitely don't want it in exec-all.h.
I have no idea what would be the best place for the prototype, then. CCing the people who introduced the function, in case they have any suggestion. Anyway, I don't want to make this series depend on dealing with the virtio default-endianness mess, so in the next version I will drop this patch and simply put the prototype inside tests/x86-stub.c. -- Eduardo
