On 12/12/2014 12:25, Peter Maydell wrote: > On 12 December 2014 at 09:30, Leon Alrae <leon.al...@imgtec.com> wrote: >> The array was "used" in a block of code which has never been enabled. >> Therefore >> removing the array as well as 700 lines of never used code. > > That's quite a lot to remove -- are you sure we're never going to want > to disassemble mips16 insns in future?
I quickly tried to enable it but it doesn't seem to be complete. For example it requires "extern const struct mips_opcode mips16_opcodes[]" which isn't anywhere in the codebase. Moreover, according to the git blame it has always been disabled since 2005 thus in my opinion there is no point in keeping this code. I do want to disassemble mips16 insns, if someone has proper implementation I'm more than happy to include it. Regards, Leon
