On 12/12/14 14:11, Peter Maydell wrote:
> On 9 December 2014 at 01:13, Laszlo Ersek <ler...@redhat.com> wrote:
>> In the next patch we'd like to reuse the image decompression facility
>> without installing the output as a ROM at a specific guest-phys address.
>>
>> In addition, expose LOAD_IMAGE_MAX_GUNZIP_BYTES, because that's a
>> straightforward "max_sz" argument for the new load_image_gzipped_buffer().
>>
>> Signed-off-by: Laszlo Ersek <ler...@redhat.com>
>> ---
>
>> +int load_image_gzipped(const char *filename, hwaddr addr, uint64_t max_sz)
>> +{
>> + int bytes;
>> + uint8_t *data;
>> +
>> + bytes = load_image_gzipped_buffer (filename, max_sz, &data);
>
> Doesn't checkpatch complain about the space before the "(" here?
(Checkpatch? What's that? :))
It sure does.
WARNING: space prohibited between function name and open parenthesis '('
Obviously, the edk2 coding style *requires* that damn space. I got so
used to it that it slipped in here.
Thanks!
Laszlo
>
> Otherwise:
> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
>
> -- PMM
>
