On Mon, Dec 08, 2014 at 01:07:42AM -0500, Jeff Cody wrote:
> Minor cleanup.
>
> Signed-off-by: Jeff Cody <jc...@redhat.com>
> ---
> block/vhdx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/block/vhdx.c b/block/vhdx.c
> index 12bfe75..f1e1e2e 100644
> --- a/block/vhdx.c
> +++ b/block/vhdx.c
> @@ -1109,8 +1109,8 @@ static coroutine_fn int vhdx_co_readv(BlockDriverState
> *bs, int64_t sector_num,
> /* check the payload block state */
> switch (s->bat[sinfo.bat_idx] & VHDX_BAT_STATE_BIT_MASK) {
> case PAYLOAD_BLOCK_NOT_PRESENT: /* fall through */
> - case PAYLOAD_BLOCK_UNDEFINED: /* fall through */
> - case PAYLOAD_BLOCK_UNMAPPED: /* fall through */
> + case PAYLOAD_BLOCK_UNDEFINED:
> + case PAYLOAD_BLOCK_UNMAPPED:
> case PAYLOAD_BLOCK_ZERO:
> /* return zero */
> qemu_iovec_memset(&hd_qiov, 0, 0, sinfo.bytes_avail);
> @@ -1280,8 +1280,8 @@ static coroutine_fn int vhdx_co_writev(BlockDriverState
> *bs, int64_t sector_num,
>
> /* fall through */
> case PAYLOAD_BLOCK_NOT_PRESENT: /* fall through */
> - case PAYLOAD_BLOCK_UNMAPPED: /* fall through */
> - case PAYLOAD_BLOCK_UNDEFINED: /* fall through */
> + case PAYLOAD_BLOCK_UNMAPPED:
> + case PAYLOAD_BLOCK_UNDEFINED:
> bat_prior_offset = sinfo.file_offset;
> ret = vhdx_allocate_block(bs, s, &sinfo.file_offset);
> if (ret < 0) {Fall through comments are used by some static checkers. Not sure if all checkers are smart enough to propagate the comment from adjacent case statements. I would have left the comments alone but am okay with merging this. Stefan
pgpRoos0u32cF.pgp
Description: PGP signature
