Fam Zheng <f...@redhat.com> writes: > On Wed, 12/10 13:50, Markus Armbruster wrote: >> Fam Zheng <f...@redhat.com> writes: >> >> > This will make it easier to keep checkpatch.pl happy. >> > >> > Fam Zheng (2): >> > qemu-iotests: Remove traling whitespaces in *.out >> > block: Don't add trailing space in "Formating..." message >> >> Sounds like PATCH 1 breaks the test, and PATCH 2 unbreaks it. If that's >> the case, they need to be squashed. > > No. Our qemu-iotests driver ignores ending space: > > if diff -w "$reference" $tmp.out >/dev/null 2>&1 > then > echo "" > if $err > then > : > else > echo "$seq `expr $stop - $start`" >>$tmp.time > fi > else > echo " - output mismatch (see $seq.out.bad)" > mv $tmp.out $seq.out.bad > $diff -w "$reference" $seq.out.bad > err=true > fi
Right, thanks for the reminder :) > Are you happy with the "sep" or do you want a full-fledged version? Your choice. The function is kind of odd, but it's not an important one. Series Reviewed-by: Markus Armbruster <arm...@redhat.com>
