On Fr, 2014-12-05 at 16:30 +0800, arei.gong...@huawei.com wrote: > From: Gonglei <arei.gong...@huawei.com> > > If errors happen for middle items of channel_list, > qmp_query_spice_channels() returns NULL, and the variable > cur_item going out of scope leaks the storage it points to. > > The flag is a compatibility thing for older spice-server > versions. Meanwhile our minimum spice version requirement is > new enough that we should never ever see this error, and if we > do something went very seriously wrong. Let's using assert() > instead of returning NULL to avoid a memory leak. > > Suggested-by: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Gonglei <arei.gong...@huawei.com> > Reviewed-by: Eric Blake <ebl...@redhat.com>
Added to spice patch queue. thanks Gerd
