On 12/05/2014 06:18 AM, Max Reitz wrote: >> >> Should there be a way to empty a cdrom drive? That is, how do I change >> a drive from visiting a file to being empty? > > Doesn't 'eject' work?
Oh, good point. More cross-referencing documentation work, then :) At which point, THIS command can keep a mandatory 'filename', and should probably fail on "" rather than being a synonym to 'eject'. > >> Does passing the empty >> string for mandatory 'filename' do that, or should we be strict and >> state that filename is optional (omit to empty the drive) and that an >> empty string as filename is forbidden? >> >> Please also improve the documentation in qapi-schema.json to have the >> 'change' command mention that it is kept for backwards compatibility, >> but that it is no longer the preferred command and point users to >> 'blockdev-change-medium'. > > And to 'change-vnc-password'. Will do. > > Max > > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature