On 04/12/2014 12:02, Pavel Dovgaluk wrote: >> > Why do you need to do this if !cpu_can_do_io(cpu)? > We save number of executed instruction when saving interrupt or exception > event. > It leads to the call of cpu_get_instructions_counter() from cpu_exec function > (through several replay functions). It is correct (because no block is > executing > at that moment) but is different to prior usage of icount requests.
Why is !cpu_can_do_io(cpu) if no block is executing? I'm not saying the function is wrong, just that it warrants a more thorough review. Paolo
