On 27 November 2014 at 12:33, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, Nov 27, 2014 at 06:04:03PM +0800, Jason Wang wrote: >> virtio_net_handle_ctrl() and other functions that process control vq >> request call iov_discard_front() which will shorten the iov. This will >> lead unmapping in virtqueue_push() leaks mapping. >> >> Fixes this by keeping the original iov untouched and using a temp variable >> in those functions. >> >> Cc: Wen Congyang <we...@cn.fujitsu.com> >> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> >> Cc: qemu-sta...@nongnu.org >> Signed-off-by: Jason Wang <jasow...@redhat.com> > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > > Peter, can you pick this up or do you want a pull request?
I can pick it up. I was waiting a bit to check that everybody was happy that this is the correct way to fix the bug and the patch is ok... -- PMM
