On Tue, Nov 25, 2014 at 09:35:26AM -0700, Eric Blake wrote: > On 11/25/2014 04:58 AM, Markus Armbruster wrote: > > Amos Kong <ak...@redhat.com> writes: > > > >> On Tue, Nov 25, 2014 at 09:06:34AM +0100, Markus Armbruster wrote: > >>> Gerd Hoffmann <kra...@redhat.com> writes: > >>> > >>>> Ongoing discussions on how we are going to specify the console, > >>>> so tag the command as experiemntal so we can refine things in > >>>> the 2.3 development cycle. > >>>> > >>>> Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > >>>> --- > >>>> qmp-commands.hx | 12 ++++++------ > >>> > >>> Don't you need to patch qapi-schema.json, too? > >> > >> Not necessary in function level. > > > > s/need to/want to/? > > Yes, if you are going to mark the HMP command experimental, please also > mark the QMP command as experimental.
Gerd's patch wasn't make hmp command experimental, but QMP. Inputted
command will be compared with .name field in qmp-commands.hx, not
qapi-schema.json. The command name in qapi-schema.json only effects
the function name.
But it's good to also update qapi-schema.json.
--
Amos.
signature.asc
Description: Digital signature
