* David Gibson (da...@gibson.dropbear.id.au) wrote:
> On Thu, Oct 16, 2014 at 04:26:55PM +0800, zhanghailiang wrote:
> > On 2014/10/4 1:47, Dr. David Alan Gilbert (git) wrote:
> > >From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
> [snip]
>
> > >+ case MIG_RPCOMM_ACK:
> > >+ tmp32 = be32_to_cpup((uint32_t *)buf);
> > >+ DPRINTF("RP: Received ACK 0x%x", tmp32);
> > >+ atomic_xchg(&ms->rp_state.latest_ack, tmp32);
> >
> > I didn't see *ms->rp_state.latest_ack* been used elsewhere, what's it used
> > for?;)
>
> Also, you don't appear to use tmp32 after that point, so what's the
> reason for the exchange, rather than just an assignment?
I've killed the 'latest_ack' off; I've kept the DPRINTF (and might turn it into
a trace).
Dave
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_
> _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
