On Mon, 2014-10-27 at 19:34 +0200, Marcel Apfelbaum wrote: > Hot-plugging a device that has a romfile (either supplied by user > or built-in) using rombar=0 option is a user error, > do not allow the device to be hot-plugged. Hi Michael,
The series has been reviewed, can you please add it to your next PULL request? Thanks, Marcel > > v3 -> v4: > - Fixed a typo in the commit (Eric Blake) > > v2 -> v3: > - Reverse the decision to forbid the hotplug on user error (Michael S. > Tsirkin) > - Split the patch in two, first part being a separate fix (Markus > Armbruster) > > v1 -> v2: > After a discussion with Michael, Paolo and Alex, this > patch silent drops the romfile instead of not allowing > the hotplug. > > Marcel Apfelbaum (2): > hw/pci: fixed error flow in pci_qdev_init > hw/pci: fixed hotplug crash when using rombar=0 with devices having > romfile > > hw/pci/pci.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) >
