On 2014-11-12 at 05:41, Eric Blake wrote:
On 11/11/2014 06:34 AM, Max Reitz wrote:
Add a command line option for adding a QMP monitor using pretty JSON
formatting.

Signed-off-by: Max Reitz <mre...@redhat.com>
---
  qemu-options.hx |  8 ++++++++
  vl.c            | 15 ++++++++++-----
  2 files changed, 18 insertions(+), 5 deletions(-)

Minor grammar suggestions:

diff --git a/qemu-options.hx b/qemu-options.hx
index da9851d..bc7b4c2 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2788,6 +2788,14 @@ STEXI
  @findex -qmp
  Like -monitor but opens in 'control' mode.
  ETEXI
+DEF("qmp-pretty", HAS_ARG, QEMU_OPTION_qmp_pretty, \
+    "-qmp-pretty dev like -qmp but uses pretty JSON formatting\n",
maybe s/dev like -qmp/dev: like -qmp,/

+    QEMU_ARCH_ALL)
+STEXI
+@item -qmp-pretty @var{dev}
+@findex -qmp-pretty
+Like -qmp but uses pretty JSON formatting.
maybe s/-qmp/-qmp,/


That's what I wrote at first, but then I saw the entry above: "Like -monitor but opens in 'control' mode" and decided to stay consistent.

Either way,
Reviewed-by: Eric Blake <ebl...@redhat.com>

Thanks!

Max

Reply via email to