On 06/11/2014 17:09, Andrew Jones wrote: > + if (sockets * cores * threads != max_cpus) { > + fprintf(stderr, "cpu topology: " > + "sockets (%u) * cores (%u) * threads (%u) != max_cpus > (%u)\n", > + sockets, cores, threads, max_cpus); > + exit(1); > + }
I think this would cause too many failures in the wild. Perhaps error out if it is lower, and warn if sockets * cores * threads > max_cpus since we actually allow hot-plug a thread at a time? Paolo