On Fri, Mar 05, 2010 at 11:15:45AM +0000, Paul Brook wrote:
> > TCG internal helpers only access to the values passed in arguments, and
> > do not modify the CPU internal state. Thus they can be declared as
> > const and pure.
>
> I think this needs an explanatory comment. It's not immediately obvious that
> tcg_gen_helperN and tcg_gen_helper{32,64} have significantly different
> semantics.
What do you mean exactly? Mentioning explicitly tcg_gen_helper{32,64}
instead of "TCG internal helpers".
> tcg/README also needs updating, specifically:
>
> "* Helpers:
>
> Using the tcg_gen_helper_x_y it is possible to call any function
> taking i32, i64 or pointer types. Before calling an helper, all
> globals are stored at their canonical location and it is assumed that
> the function can modify them. In the future, function modifiers will
> be allowed to tell that the helper does not read or write some globals.
> "
>
Fully agreed, but it is not a change introduce by this patch series.
I'll submit a patch later.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurel...@aurel32.net http://www.aurel32.net
