So that standard pci host device can share them. Signed-off-by: Hu Tao <hu...@cn.fujitsu.com> --- hw/pci-host/piix.c | 20 -------------------- hw/pci-host/q35.c | 7 ------- hw/pci/pci_host.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 32 insertions(+), 27 deletions(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index eb92bde..683465c 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -256,14 +256,8 @@ static void i440fx_pcihost_get_pci_hole64_end(Object *obj, Visitor *v, static void i440fx_pcihost_initfn(Object *obj) { - PCIHostState *s = PCI_HOST_BRIDGE(obj); I440FXState *d = I440FX_PCI_HOST_BRIDGE(obj); - memory_region_init_io(&s->conf_mem, obj, &pci_host_conf_le_ops, s, - "pci-conf-idx", 4); - memory_region_init_io(&s->data_mem, obj, &pci_host_data_le_ops, s, - "pci-conf-data", 4); - object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_START, "int", i440fx_pcihost_get_pci_hole_start, NULL, NULL, NULL, NULL); @@ -283,18 +277,6 @@ static void i440fx_pcihost_initfn(Object *obj) d->pci_info.w32.end = IO_APIC_DEFAULT_ADDRESS; } -static void i440fx_pcihost_realize(DeviceState *dev, Error **errp) -{ - PCIHostState *s = PCI_HOST_BRIDGE(dev); - SysBusDevice *sbd = SYS_BUS_DEVICE(dev); - - sysbus_add_io(sbd, PC_PCI_CONFIG_ADDR, &s->conf_mem); - sysbus_init_ioports(sbd, PC_PCI_CONFIG_ADDR, 4); - - sysbus_add_io(sbd, PC_PCI_CONFIG_DATA, &s->data_mem); - sysbus_init_ioports(sbd, PC_PCI_CONFIG_DATA, 4); -} - static int i440fx_initfn(PCIDevice *dev) { PCII440FXState *d = I440FX_PCI_DEVICE(dev); @@ -755,8 +737,6 @@ static void i440fx_pcihost_class_init(ObjectClass *klass, void *data) PCIHostBridgeClass *hc = PCI_HOST_BRIDGE_CLASS(klass); hc->root_bus_path = i440fx_pcihost_root_bus_path; - dc->realize = i440fx_pcihost_realize; - dc->fw_name = "pci"; dc->props = i440fx_props; } diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 9e66835..81eddd7 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -138,18 +138,11 @@ static void q35_host_class_init(ObjectClass *klass, void *data) dc->realize = q35_host_realize; dc->props = mch_props; set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); - dc->fw_name = "pci"; } static void q35_host_initfn(Object *obj) { Q35PCIHost *s = Q35_HOST_DEVICE(obj); - PCIHostState *phb = PCI_HOST_BRIDGE(obj); - - memory_region_init_io(&phb->conf_mem, obj, &pci_host_conf_le_ops, phb, - "pci-conf-idx", 4); - memory_region_init_io(&phb->data_mem, obj, &pci_host_data_le_ops, phb, - "pci-conf-data", 4); object_initialize(&s->mch, sizeof(s->mch), TYPE_MCH_PCI_DEVICE); object_property_add_child(OBJECT(s), "mch", OBJECT(&s->mch), NULL); diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c index f2a69ea..406c747 100644 --- a/hw/pci/pci_host.c +++ b/hw/pci/pci_host.c @@ -176,12 +176,44 @@ const MemoryRegionOps pci_host_data_be_ops = { .endianness = DEVICE_BIG_ENDIAN, }; +static void pci_host_initfn(Object *obj) +{ + PCIHostState *phb = PCI_HOST_BRIDGE(obj); + + memory_region_init_io(&phb->conf_mem, obj, &pci_host_conf_le_ops, phb, + "pci-conf-idx", 4); + memory_region_init_io(&phb->data_mem, obj, &pci_host_data_le_ops, phb, + "pci-conf-data", 4); +} + +static void pci_host_realize(DeviceState *dev, Error **errp) +{ + PCIHostState *s = PCI_HOST_BRIDGE(dev); + SysBusDevice *sbd = SYS_BUS_DEVICE(dev); + + sysbus_add_io(sbd, PC_PCI_CONFIG_ADDR, &s->conf_mem); + sysbus_init_ioports(sbd, PC_PCI_CONFIG_ADDR, 4); + + sysbus_add_io(sbd, PC_PCI_CONFIG_DATA, &s->data_mem); + sysbus_init_ioports(sbd, PC_PCI_CONFIG_DATA, 4); +} + +static void pci_host_class_init(ObjectClass *klass, void *data) +{ + DeviceClass *dc = DEVICE_CLASS(klass); + + dc->realize = pci_host_realize; + dc->fw_name = "pci"; +} + static const TypeInfo pci_host_type_info = { .name = TYPE_PCI_HOST_BRIDGE, .parent = TYPE_SYS_BUS_DEVICE, .abstract = true, .class_size = sizeof(PCIHostBridgeClass), + .class_init = pci_host_class_init, .instance_size = sizeof(PCIHostState), + .instance_init = pci_host_initfn, }; static void pci_host_register_types(void) -- 1.9.3