On 2014/11/2 13:06, Michael Tokarev wrote: > 31.10.2014 09:11, arei.gong...@huawei.com wrote: >> From: Gonglei <arei.gong...@huawei.com> >> >> commit 5193e5fb (tap: factor out common tap initialization) >> introduce net_init_tap_one(). But it's inapposite that close >> fd in net_init_tap_one(), we should lay it in the caller, >> becuase some caller needn't to close it if we get the fd >> by monitor_handle_fd_param(). >> >> On the other hand, in other exceptional branch fd doesn't >> be closed, so that's incomplete. > > Applied to -trivial, with grammar tweaking in commit message > and with slightly better (in my opinion) subject, like this: >
Ack. Thanks for your work. :) Best regards, -Gonglei > tap: do not close(fd) in net_init_tap_one() > > commit 5193e5fb (tap: factor out common tap initialization) > introduce net_init_tap_one(). But it's inappropriate that > we close fd in net_init_tap_one(), we should lay it in the > caller, becuase some callers needn't to close it if we get > the fd by monitor_handle_fd_param(). > > On the other hand, in other exceptional branches fd isn't > closed, so that's incomplete anyway. > > Thanks, > > /mjt
