On 10/28/2014 11:04 PM, Fam Zheng wrote: > Node name is a better identifier of BDS. > > We will want to query statistics of a BDS node buried in the BDS graph, > so reporting the node's name if there is one will do the good.
s/do the good/do the trick/
> +++ b/qapi/block-core.json
> @@ -408,6 +408,8 @@
> # @device: #optional If the stats are for a virtual block device, the name
> # corresponding to the virtual block device.
> #
> +# @device: #optional The node name of the device. (Since 2.3)
Yeah, we missed soft freeze and this is a feature, so your versioning is
correct.
The node-name would become non-optional once Jeff's patches auto-assign
a node name, right?
> +#
> # @stats: A @BlockDeviceStats for the device.
> #
> # @parent: #optional This describes the file block device if it has one.
> @@ -418,7 +420,8 @@
> # Since: 0.14.0
> ##
> { 'type': 'BlockStats',
> - 'data': {'*device': 'str', 'stats': 'BlockDeviceStats',
> + 'data': {'*device': 'str', '*node-name': 'str',
> + 'stats': 'BlockDeviceStats',
> '*parent': 'BlockStats',
Indentation looks odd here. Fix that, and:
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
