On 10/27/2014 02:06 AM, Max Reitz wrote: > On 2014-10-24 at 18:31, Eric Blake wrote: >> On 10/24/2014 07:57 AM, Max Reitz wrote: >>> Add a test for qcow2's fast bdrv_make_empty implementation on images >>> without internal snapshots. >>>
>>> +for event in l1_update empty_image_prepare reftable_update >>> refblock_alloc; do >> Is it also worth a test where no I/O error occurs, to be sure we cover >> the common case output? Maybe by adding '' to this list... >> > That should be covered by the test added by the previous patch. I hope. Ah, that does look like it covers it. Maybe it's worth a comment such as 'this test covers failures in the middle of an operation; success is covered by test 097'? Up to you. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
