Hi On Mon, Oct 27, 2014 at 9:08 AM, Gerd Hoffmann <kra...@redhat.com> wrote:
> > +static void spice_chr_accept_input(struct CharDriverState *chr) > > +{ > > + SpiceCharDriver *s = chr->opaque; > > + > > + spice_server_char_device_wakeup(&s->sin); > > Does this build on older spice versions? I'd suspect this needs #if > SPICE_SERVER_VERSION too ... There is already a spice_server_char_device_wakeup() call there. On older servers, this additional call will trigger just a read try. With the proposed patch in Spice server, it will do read & write try (I didn't see the need to create a new function to do only read or write, both should be fine) -- Marc-André Lureau