On 10/21/2014 06:03 AM, Pavel Dovgalyuk wrote: > + dc->repz_opt = dc->jmp_opt > + /* Do not optimize repz jumps at all in icount mode, > because > + rep movsS instructions are execured with different > paths > + in repz_opt and !repz_opt modes. The first one was > used > + always except single step mode. And this setting > + disables jumps optimization and control paths become > + equivalent in run and single step modes. > + Now there will be no jump optimization for repz in > + trace and replay modes and there will always be an > + additional step for ecx=0. > + */ > + || use_icount;
My aesthetics are offended by the placement of this comment. Please write /* Comment */ dc->repz_opt = x || y; That said, surely that test should be !use_icount. r~
