On Wed, Oct 22, 2014 at 08:39:59AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" <m...@redhat.com> writes: > > > On Tue, Oct 21, 2014 at 03:29:14PM +0200, Markus Armbruster wrote: > >> "Michael S. Tsirkin" <m...@redhat.com> writes: > >> > >> > On Tue, Oct 21, 2014 at 02:22:41PM +0200, Markus Armbruster wrote: > [...] > >> >> My patch to get_maintainers.pl triggered a whole thread, while the > >> >> message I sent on MAINTAINERS coverage got just one reply so far, and > >> >> even that one's really just about get_maintainers.pl. Disappointing. > >> >> Looks like we're still looking for an easy technical fix. I doubt there > >> >> is one. > >> > > >> > At least for myself, that's because I'm Cc'd directly on the patch > >> > but not on the MAINTAINERS coverage mail. > >> > And that's ... because get_maintainers picks my mail from git? > >> > > >> > See how it's useful now? > >> > >> Except that's not what happened. > >> > >> $ scripts/get_maintainer.pl --git-fallback -f > >> scripts/get_maintainer.pl > >> > >> No output. I picked you from git-log manually. > > > > Weird. > > It works for me: > > ./scripts/get_maintainer.pl -f scripts/get_maintainer.pl > > "Michael S. Tsirkin" <m...@redhat.com> (commit_signer:1/1=100%) > > > > Maybe --git-fallback is broken? > > I tried on master (i.e. without my patch, clean tree, with and without > --git-fallback. Just tried it again, same result.
Well ... I don't know why. It's clearly a bug. Different perl version? Different git version? Can you try tracing it? Does it exec git? > > Another reason to defer this patch ... > > Can't see why. So we can debug and fix --git-fallback. > But I'm content to defer it until the patch traffic > triggered by this discussion quiets down, so we can reevaluate. > > [...]
