Patch posted. I will post another one for virt-manager. -Wei
On 10/09/2014 05:16 PM, Eduardo Habkost wrote: > On Thu, Oct 09, 2014 at 11:08:03PM +0200, Paolo Bonzini wrote: >> Il 09/10/2014 22:22, Wei Huang ha scritto: >>> >>> Given that back-ward compatibility is a concern, will the following work? >>> >>> 1. Instead of bailing out, print a warning message (e.g. to log file via >>> error_report) in QEMU. >>> 2. [optional] Eduardo Habkost suggested that we can create a new machine >>> model which more strictly checks threads=n option for AMD. For any >>> existing machine config, we don't force it; but warning message still >>> applies. This is optional because it is a bit over-killed IMO. >>> 3. Gives out a warning in virt-manager as well. This is similar to >>> "Overcomming CPUs will slow down performance" in current virt-manager >>> screen. The message will read "Chosen CPU model doesn't support >>> hyperthreading" or something similar. >> >> I like (1) and (3). > > I don't think we really need (2), either. The current problem is just > user confusion, so properly warning the user is the best thing to do. >
