On 10/08/2014 09:43 PM, Jiri Gaisler wrote: > On 10/08/2014 05:38 PM, Andreas Färber wrote: >> Hi, >> >> Am 08.10.2014 um 16:19 schrieb Fabien Chouteau: >>> From: Jiri Gaisler <j...@gaisler.se> >>> >>> AMBA plug&play is used by kernels to probe available devices (Timers, >>> UART, etc...). This is a static declaration of devices implemented in >>> QEMU. In the future, a more advanced version could compute those >>> information directly from the device tree. >> >> Interesting. There's quite some magic numbers in the read functions; I >> wonder if you could read them via QOM if you actually give the devices a >> canonical path or search by type? You may want to peek at ACPI code. > > > The plug&play area is similar in function to the PCI configuration > space, indicating vendor/device ID's, address range, interrupt number > etc. of on-chip IP cores. The 'magic' numbers could be generated by > generic functions taking these parameters as inputs. This would > certainly make the code more readable, and easily extended in the > future. Would such a solution be acceptable? > >
That would be a great improvement, then we could try to plug it with the QOM API to generate automatically the data.
