Eric Blake <ebl...@redhat.com> writes: > On 10/02/2014 08:51 AM, Markus Armbruster wrote: >> Executed in this order, drive_del and device_del's automatic drive >> deletion take notoriously tricky special paths. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> tests/drive_del-test.c | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/tests/drive_del-test.c b/tests/drive_del-test.c > >> + /* Complication: ignore DEVICE_DELETED event */ >> + qmp_discard_response("{'execute': 'device_del'," > > Still not a fan of single quotes in QMP, but it's existing style. > > >> +static void test_drive_del_device_del(void) >> +{ >> + /* Start with a drive used by an device that unplugs instantaneously */ > > s/an device/a device/ > > New tests are always good; with the typo fix: > Reviewed-by: Eric Blake <ebl...@redhat.com>
I'll get that fixed, either on commit, or via respin. Thanks!