On Wed, Oct 01, 2014 at 12:20:18AM +0200, Paolo Bonzini wrote: > Il 30/09/2014 20:26, Eduardo Habkost ha scritto: > > Reasoning for each object file included in the test binary: > > * qom/cpu.o - for TYPE_CPU. Dependencies: > > * qom/qom-qobject.o > > * qom/qdev.o - for TYPE_DEVICE. Dependencies: > > * qom/container.o > > * vmstate.o. Dependencies: > > * qemu-file.o > > * hw/core/hotplug.o > > * hw/core/irq.o > > * hw/core/fw-path-provider.o > > * hw/core/qdev-properties.o > > * qom/object.o - for TYPE_OBJECT > > * x86_64-softmmu/target-i386/machine.o - for vmstate_x86_cpu > > * qemu-log.o - for the logging API, used by target-i386/cpu.c > > * libqemuutil.a - for QAPI visitors, error API, and other symbols > > * libqemustub.a - existing stubs, including: savevm, monitor symbols > > > > The remaining symbols used by target-i386/cpu.c were added as stubs to > > either tests/vl-stub.c and tests/x86-stub.c. > > Nice. Luckily qemu-log.o doesn't bring in everything. > > I think vl-stub.c has to be re-evaluated after your QOM accelerator > patch goes in. > > tests/x86-stub.c perhaps can be moved to target-i386/test-stubs.c?
I was trying to keep all test code inside tests/. But perhaps all the target-specific test code (including test-x86-cpu.c) could be moved to target directories, and we could build/run the target-specific test cases from Makefile.target. That should simplify some of the logic I have added, and fix the build dependency problem I mentioned in the patch description. -- Eduardo
