The Tuesday 30 Sep 2014 à 22:08:12 (+0300), Boris Sukholitko wrote : > On Tue, Sep 30, 2014 at 12:46 AM, Benoît Canet <benoit.ca...@irqsave.net> > wrote: > > The Friday 26 Sep 2014 à 18:19:55 (+0300), Boris Sukholitko wrote : > >> This patchset is a small rebase of the 9p live migration patches made a > >> year > >> ago by Benoit Canet. > >> > >> See http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg02190.html > >> for the previous thread. > >> > >> I took the liberty to drop the second patch (waiting for completion of 9p > >> operations) as it wasn't working in my testing. > > > > It's probable that the second patch has bitrot but I remember I was asked to > > write it for a meaningfull reason. > > AFAICT, the reason was to drain requests queue before saving the state. > > Unfortunately, releasing BQL haven't led to the callbacks being executed. > Therefore deadlock ensued. > > > Maybe you should give it a bit more love to resurect it properly. > > > > I probably should. Still, IMHO, the two patches work good enough > to deserve merging on their own right :)
I am afraid nobody will want to merge a patchset where there is a theorical potential bug. It should work as well on paper as on silicon. Best regards Benoît > > Thanks, > Boris. > > > Best regards > > > > Benoît > > > >> > >> Thanks, > >> Boris. > >> > >> Boris Sukholitko (2): > >> virtio-9p: Add support for 9p migration. > >> virtio-9p: Remove migration blockers. > >> > >> hw/9pfs/virtio-9p-device.c | 152 > >> +++++++++++++++++++++++++++++++++++++++++++++ > >> hw/9pfs/virtio-9p.c | 24 ------- > >> hw/9pfs/virtio-9p.h | 2 - > >> 3 files changed, 152 insertions(+), 26 deletions(-) > >> > >> -- > >> 2.0.2 > >> > >> >
