On 02/25/2010 02:04 PM, Michael S. Tsirkin wrote:
Clobbering memory
>  is not necessary since we are only caring about blocking assignments of
>  "env", which is by definition in a register

Then I think you should add that as a clobber. Otherwise what prevents the
compiler from reordering this asm wrt assignments?

That old-style asms block scheduling of _anything_ across it (like "barrier()" in the Linux kernel). So, it is actually slightly stricter than what was there before.

I should have made clear in the commit message that this is the only change wrt hostregs_helper.h.

Paolo


Reply via email to