Il 25/09/2014 22:18, Eduardo Habkost ha scritto: > This is an attempt to write unit tests for the target-i386/cpu.c code. By > now, I > just implemented 3 simple test cases, to ensure X86CPU objects can be created, > and to ensure the CPU features are set properly depending on the CPU model > table.
+ qemu-log.o \ + qom/object.o qom/qom-qobject.o qom/cpu.o qom/container.o \ + hw/core/qdev.o hw/core/qdev-properties.o hw/core/irq.o hw/core/fw-path-provider.o hw/core/hotplug.o \ + vmstate.o qemu-file.o $(util-obj-y) \ + x86_64-softmmu/cpus.o x86_64-softmmu/target-i386/machine.o \ + tests/vl-stub.o tests/x86-stub.o tests/coroutine-stub.o tests/monitor-stub.o tests/aio-stub.o tests/timer-stub.o tests/block-stub.o \ + stubs/reset.o stubs/sysbus.o stubs/vmstate.o stubs/fdset-remove-fd.o stubs/mon-printf.o stubs/qtest.o stubs/vm-stop.o Do you really need cpus.c? That's what brings in most dependencies, and everything else should be included in libqemustub.a. Also, util-obj-y should be replaced with libqemuutil.a In any case, most of these files are not needed by the linux-user version of cpu.c, so I would need to know what exactly forces you to include each of the files. Also, would it be possible to do these tests via qtest and qom-get/qom-set? That said, please feel free to send patches 1-3 now, via qemu-trivial. Thanks, Paolo
