Am 22.09.2014 um 17:57 schrieb Paolo Bonzini: > Il 22/09/2014 15:15, Laszlo Ersek ha scritto: >> $ git grep -E '\<qemu_register(_pc)?_machine\>' | wc -l >> 115 >> >> Even if we just count the clusters, they're way too many: >> >> $ git grep -E '\<machine_init\>' | wc -l >> 66 > > There are just a couple of multi-machine clusters (well, three: pseries, > pc, q35). So the default clusters can just default to the machine type.
I would've gone even simpler and special-cased pc/q35 and "none" (like we did for -cpu "host") in the comparison function, sparing us any big interface work. Therefore from my point of review, this was merely about how we implement the comparison function. No reason to get a heart attack IMO. Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
