Il 16/09/2014 18:26, Michael S. Tsirkin ha scritto: > Right so types should be explicit. > If an arbitrary string isn't allowed, this should be documented. > It's not great as is: what's the format for macaddr? AA:BB:CC:DD:EE:FF? > aa:bb:cc:dd:ee:ff? aabbccddeeff? 0xaabbccddeeff? > But just saying "string" is going in the wrong direction imho.
That's the purpose of documentation (docs/qdev-device-use.txt), and even then is better done with examples. I don't think doing it in -device foo,help (which I'm not even sure is particularly helpful. "ip link help" doesn't document the format of a MAC address, either. I'm sympathetic towards fixing the drive->str change, but I have no idea how to do it. Paolo
