On So, 2014-09-14 at 22:08 +0300, Valentin Manea wrote: > Hi Gerd, > > I'm working on improving the OpenRISC support for QEMU and recently I got in > one problem with qemu_pixelformat_from_pixman(). It seems quite recently the > ui/console.c code has started using it for big endian as well but the new > change > breaks my existing framebuffer patches.
> I was wondering if there is any reason not to return PIXMAN_b8g8r8x8 also > for > big endian? In the worst case scenario it would be compatible to the previous > code. It's a bug indeed (and it is the one which breaks ppc guest display on x86_64 hosts with SDL). > If you are OK, I would like to submit this patch: > diff --git a/ui/qemu-pixman.c b/ui/qemu-pixman.c > index 30c7fdd..1f6fea5 100644 > --- a/ui/qemu-pixman.c > +++ b/ui/qemu-pixman.c > @@ -80,7 +80,7 @@ pixman_format_code_t qemu_default_pixman_format(int bpp, > bool > native_endian) > case 24: > return PIXMAN_b8g8r8; > case 32: > - return PIXMAN_b8g8r8a8; > + return PIXMAN_b8g8r8x8; > break; > } > } Fix is correct. cheers, Gerd
