On 09/11/2014 01:34 PM, Benoît Canet wrote: > The Thursday 11 Sep 2014 à 21:12:44 (+0200), Markus Armbruster wrote : >> Benoît Canet <benoit.ca...@irqsave.net> writes: >> >>>> + blk_bs(blk_by_legacy_dinfo(dinfo))); >>> >>> This seems to be a fairly common pattern: "blk_bs(blk_by_legacy_dinfo())". >>> How about a helper function ? >> >> Yes, except the pattern is going to evaporate in patch 14 :) > > haha
Still, worth mentioning this fact in the commit message, rather than making reviewers guess at it (that is, add a sentence something like: This commit mechanically introduces long lines via repetitive pattern replacement that will be shortened in a later patch -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
