Eric Blake <ebl...@redhat.com> writes: > On 09/10/2014 02:13 AM, Markus Armbruster wrote: >> device_name[] is can become non-empty only in bdrv_new_named() and > > s/is //
Fixing, thanks! >> bdrv_move_feature_fields(). The latter is used only to undo damage >> done by bdrv_swap(). The former is called only by blk_new_with_bs(). >> Therefore, when a BlockDriverState's device_name[] is non-empty, then >> it's owned by a BlockBackend. >> >> The converse is also true, because blk_attach_bs() is called only by >> blk_new_with_bs() so far. >> >> Furthermore, blk_new_with_bs() keeps the two names equal. >> >> Therefore, device_name[] is redundant. Eliminate it. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> ---
