On Wed, Sep 10, 2014 at 12:07:22PM +0200, Paolo Bonzini wrote: > Il 10/09/2014 13:04, Michael S. Tsirkin ha scritto: > >> > This patch disables raising an irq while loading the state of PCI > >> > bridge. > >> > Because the i8259 has not been deserialized yet, raising an interrupt > >> > could bring the system out-of-sync with the migration source. For > >> > example, > >> > the migration source could have masked the interrupt in the i8259. > >> > On the > >> > destination, the i8259 device model would not know that yet and would > >> > trigger an interrupt in the CPU. > >> > > >> > This patch eliminates raising an irq and just restores the calculated > >> > state fields in post_load function. Interrupt state will be > >> > deserialized > >> > separately through the IRR field of the i8259. > > Yes, thanks! > > Except imho it's a bit better to s/raising/setting/ in the last paragraph. > > And pretty much everywhere else, not just in the last paragraph. > > Thanks! > > Paolo
Right. With these minor changes, you can attach Reviewed-by: Michael S. Tsirkin <m...@redhat.com>
