On 8 September 2014 13:37, Martin Galvan
<martin.gal...@tallertechnologies.com> wrote:
> On Sat, Sep 6, 2014 at 8:00 AM, Peter Crosthwaite
> <peter.crosthwa...@xilinx.com> wrote:
>> On Sat, Sep 6, 2014 at 8:42 PM, Peter Maydell <peter.mayd...@linaro.org>
>> wrote:
>>> On 6 September 2014 03:45, Peter Crosthwaite
>>> <peter.crosthwa...@xilinx.com> wrote:
>>>> CC Alistair who is into ARMv7M
>>>>
>>>> On Sat, Sep 6, 2014 at 4:39 AM, Martin Galvan
>>>> <martin.gal...@tallertechnologies.com> wrote:
>>>>> }
>>>>>>
>>>>>> if (env->cp15.c1_sys & SCTLR_V) {
>>>>>> - env->regs[15] = 0xFFFF0000;
>>>>>> + env->regs[15] = 0xFFFF0000;
>>>>
>>>> Out of scope change.
>
> Oh, I must've changed that and forgotten it was gonna be included on
> the patch. Still, quoting
> http://wiki.qemu.org/Contribute/SubmitAPatch:
>
> "It's OK to fix coding style issues in the immediate area (few lines)
> of the lines you're changing. "
Yeah, this kind of thing is a judgement call. In this
case I kind of agree with Peter so I'll just split it
out into a separate patch for you when I apply this
to my target-arm tree.
>>> So the comment is actually incorrect and we should probably
>>> delete it.
>>
>> Yep, thats what I was thinking but your reasonings are more correct than
>> mine.
>
> Should I send a new patch version, just to remove that one comment?
No, don't bother, I'll just remove it when I apply this
to target-arm.
(with the tweaks I'm going to make as above)
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
