Eric Blake <ebl...@redhat.com> writes: > On 09/03/2014 05:10 AM, Kevin Wolf wrote: > >>>>> @@ -1150,7 +1150,8 @@ >>>>> 'data': [ 'archipelago', 'file', 'host_device', 'host_cdrom', >>>>> 'host_floppy', >>>>> 'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat', 'blkdebug', >>>>> 'blkverify', 'bochs', 'cloop', 'cow', 'dmg', 'parallels', >>>>> 'qcow', >>>>> - 'qcow2', 'qed', 'raw', 'vdi', 'vhdx', 'vmdk', 'vpc', >>>>> 'quorum' ] } >>>>> + 'qcow2', 'qed', 'raw', 'vdi', 'vhdx', 'vmdk', 'vpc', >>>>> 'quorum', >>>>> + 'null' ] } >>>> >>>> As mentioned elsewhere, you probably want 'null' AND 'null-co'. Bummer >>>> that this list is mostly alphabetical, but that 'quorum' and 'null' are >>>> out of order. >>> >>> I'll add null-co to the list. But this list is a bit far from alphabetical: >>> >>> archipelago, ..., vvfat, blkdebug,... >> >> Actually it's pretty close to alphabetical as the secondary criterion >> (the primary one is that all protocols are listed first, and only then >> the formats). > > Then a (separate) patch that lists: > > 'data': [ > # protocols > list..., > # formats > list... > ] > > might be nice :)
I doubt differentiating between protocols and formats is useful here. Just sort it alphabetically.
