Il 01/09/2014 11:33, Zhang Min ha scritto: > From: subo <[email protected]> > > When the vm reboot, it will call virtio_scsi_handle_event(), > for vhost-scsi device,vdev is VIRTIO_SCSI_COMMON, not VIRTIO_SCSI, > if vdev convert to the VIRTIO_SCSI, it will cause qemu crash. > > Signed-off-by: Zhang Min <[email protected]> > Signed-off-by: subo <[email protected]> > --- > hw/scsi/virtio-scsi.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c > index 86aba88..7d3bc49 100644 > --- a/hw/scsi/virtio-scsi.c > +++ b/hw/scsi/virtio-scsi.c > @@ -630,7 +630,11 @@ static void virtio_scsi_push_event(VirtIOSCSI *s, > SCSIDevice *dev, > > static void virtio_scsi_handle_event(VirtIODevice *vdev, VirtQueue *vq) > { > - VirtIOSCSI *s = VIRTIO_SCSI(vdev); > + VirtIOSCSI *s; > + > + s = (VirtIOSCSI *)object_dynamic_cast((Object *)vdev, TYPE_VIRTIO_SCSI); > + if (!s) > + return; > > if (s->events_dropped) { > virtio_scsi_push_event(s, NULL, VIRTIO_SCSI_T_NO_EVENT, 0); >
Should be already fixed in 2.1 by commit 91d670f (virtio-scsi: define dummy handle_output for vhost-scsi vqs, 2014-06-19). Paolo
