Stefan Hajnoczi <stefa...@redhat.com> writes:
> The out label has the qemu_progress_end() and other cleanup calls.
> Always goto out in error paths so the cleanup happens.
>
> Note that bdrv_unref(NULL) is safe. We just need to initialize bs to
> NULL at the top of the function.
>
> We can now remove the obsolete bs_old_backing = NULL and bs_new_backing
> = NULL for safe mode. Originally it was necessary in commit 3e85c6fd
> ("qemu-img rebase") but became useless in commit c2abcce ("qemu-img:
> avoid calling exit(1) to release resources properly") because the
> variables are already initialized during declaration.
Please mention here that you fix exit code.from -1 to 1.
>
> Reported-by: John Snow <js...@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
[...]
