On 08/21/2014 06:22 AM, Markus Armbruster wrote: > Kevin Wolf <kw...@redhat.com> writes: >
>> The worst part is that it got a Reviewed-by which might just have fooled >> me if Fam hadn't reviewed it as well. :-/ > > This kind of idiotic error is hard to spot in review for the same reason > it's easy to make when tired. Indeed; I had merely reviewed that the patch looked sane, and not actually tested against a testsuite, so I'm glad Fam caught it. There's a reason I've been sticking with Reviewed-by and not Tested-by, although I agree that enhancing the testsuite to make sure dumb things like this get caught is worthwhile. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
