On 20.08.2014 17:14, Kevin Wolf wrote:
Am 18.07.2014 um 20:24 hat Max Reitz geschrieben:
Because blkdebug cannot simply create a configuration file, simply
refuse to reconstruct a plain filename and only generate an options
QDict from the rules instead.
Signed-off-by: Max Reitz <mre...@redhat.com>
---
Instead of this rather complicated implementation, we could decide to
just drop it and let this be handled by the default implementation. The
default implementation however cannot generate full_open_options in case
a configuration file was given; in that case, it would just return the
filename containing the name of the configuration file. On the other
hand, blkdebug is just a debug driver anyway, so it probably wouldn't
hurt too much.
I think you really want to have the config file name used here for
options that were loaded from a config file, and the explicit JSON
notation only for options explicitly specified on the command line or in
blockdev-add.
We still only have 1024 characters for bs->filename... ;-)
But who uses blkdebug anyway. *g*
I'll take a look into this, along with whether we can minimize use of
BDS.filename enough to justify completely removing it.
Max
