Lluís Vilanova <vilan...@ac.upc.edu> writes: > Also removes old "trace-event", "trace-file" and "info trace-events" HMP > commands.
We gain the ability to control trace via QMP, but lose the ability to control it via HMP, correct? > > Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu> > --- > hmp-commands.hx | 35 ----------------------- > monitor.c | 61 ---------------------------------------- > qapi-schema.json | 3 ++ > qmp-commands.hx | 27 ++++++++++++++++++ > trace/Makefile.objs | 1 + > trace/commands.json | 44 +++++++++++++++++++++++++++++ There's no precedence for keeping schema bits anywhere but in qapi/. If we decide we want to keep them with their related C parts instead, we should do so consistently, not just for trace. > trace/control.c | 13 --------- > trace/control.h | 7 ----- > trace/qmp.c | 77 > +++++++++++++++++++++++++++++++++++++++++++++++++++ > trace/simple.c | 10 +------ > trace/simple.h | 3 -- > 11 files changed, 154 insertions(+), 127 deletions(-) > create mode 100644 trace/commands.json > create mode 100644 trace/qmp.c [...]
