On 07/31/2014 11:27 PM, Benoît Canet wrote: > This header will allow to split monitor in two parts.
s/allow to split monitor in/allow splitting the monitor into/
>
> Signed-off-by: Benoit Canet <ben...@irqsave.net>
> ---
> include/monitor/monitor-system.h | 99
> ++++++++++++++++++++++++++++++++++++++++
> monitor.c | 57 ++---------------------
> 2 files changed, 102 insertions(+), 54 deletions(-)
> create mode 100644 include/monitor/monitor-system.h
>
> +struct Monitor {
> + CharDriverState *chr;
> + int reset_seen;
Should we be converting this field to bool at some point in the series?
(Probably as a separate patch, since this patch is more focused on code
motion).
> +
> +typedef struct mon_cmd_t {
This isn't typical qemu naming convention. Can we fix that up in this
series? (Probably best as a separate patch before this one)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
