On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote: > In this patch, I have made the following changes: > > * changed the DPRINT statement. > * renamed the variables. > * added noqdev variable which decides which option to use for resetting. > * added devices option which can help in resetting one or many devices > (only qdevified ones). > * updated the documentation. > > Signed-off-by: Sanidhya Kashyap <sanidhya.ii...@gmail.com> > --- > qapi-schema.json | 26 ++++++ > qmp-commands.hx | 37 ++++++++ > savevm.c | 251 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 314 insertions(+) > > +# > +# @noqdev: boolean variable which decides whether to use qdevified devices > +# or not. Will be removed when all the devices have been qdevified.
Please name this 'x-noqdev' if it is likely to be removed in the future,
to make it obvious that it is not part of the permanent API. Also, mark
it as optional, with a sane default, so that you can test the API
without being forced to supply this temporary parameter.
> +#
> +# @devices: (optional) helps in resetting particular qdevified decices
> +# that have been registered with SaveStateEntry
> +#
> +# Since 2.2
> +##
> +{ 'command': 'test-vmstates',
> + 'data': {'*iterations': 'int',
> + '*period': 'int',
> + 'noqdev': 'bool',
> + '*qdevices': 'VMStatesQdevDevices' } }
Based on my comments on 3/12, if you rename that qapi to:
{ 'type': 'VMStatesQdevDevice',
'data': { 'device': 'str' } }
then this should be
'*qdevices': [ 'VMStatesQdevDevice' ]
> +
> +- "devices": (optional) helps in resetting particular qdevified decices
s/decices/devices/
> + that have been registered with SaveStateEntry
> +
> +
> +Example:
> +
> +-> { "execute": "test-vmstates",
> + "arguments": {
> + "iterations": 10,
> + "period": 100,
> + "noqdev": false } }
If noqdev is going to disappear, I wouldn't include it in the example.
Conversely, showing how to use 'devices' might be useful.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
