On 07/23/2014 10:13 AM, Felix von Leitner wrote: > I actually have bash installed as /bin/sh and /bin/bash. > But I also have heirloom sh installed, which installs itself as /sbin/sh, and > that happened to be first in my $PATH. > > Since the makefiles use "sh script" to run the scripts, that called the > heirloom sh. > > http://heirloom.sourceforge.net/sh.html > > It is, it turns out, derived from OpenSolaris. So there you go :-) > > When I delete /sbin/sh, qemu builds.
Then the bug is not in qemu, but in your environment. Installing known-broken heirloom where it can be found first on a PATH search for sh is just asking for problems, not just with qemu, but with all SORTS of programs that expect POSIX semantics from a Linux /bin/sh. Rather than change the Makefile to invoke the script with bash, we could instead bend over backwards to rewrite the script in a way that works with non-POSIX shells (as in, flag=`expr $flag ^ 1`), but that feels backwards to me. Until someone is actively worried about porting qemu to a true Solaris environment, rather than just an heirloom-as-/bin/sh Linux environment, I don't think it's worth the effort. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature