On 07/09/2014 02:29 AM, Stefan Hajnoczi wrote:

>> +        if (enqueue)
>> +            return ret;
> 
> Please set up a git hook to run checkpatch.pl.  It will alert you when
> you violate QEMU coding style:
> http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html
> 
> I already mentioned coding style in previous patches, using a git hook
> will avoid it happening again.

Nice trick; I've added it to http://wiki.qemu.org/Contribute/SubmitAPatch

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to